[cfe-commits] PATCH: Change PPCallbacks to use Token more often

Sebastian Redl sebastian.redl at getdesigned.at
Fri Nov 19 02:52:16 PST 2010


On 19.11.2010 06:22, Chris Lattner wrote:
> On Nov 18, 2010, at 4:27 PM, Craig Silverstein wrote:
>
>> Several PPCallbacks take an SourceLocation + IdentifierInfo, rather
>> than a Token that holds the same information all in one easy-to-use
>> package.  There's no technical reason to prefer the former -- the
>> information comes from a Token originally -- and it's clumsier to use,
>> so I've changed the code to use tokens everywhere.
>>
>> Look ok to commit?
> Makes sense to me, please commit!
Make a big release note for 2.9 for this, too. I'm pretty sure I've 
heard of PPCallbacks being used by quite a few external projects.

Sebastian



More information about the cfe-commits mailing list