[cfe-commits] [Review request] CMake: Add the new option "LLVM_LIT_ARGS"

NAKAMURA Takumi geek4civic at gmail.com
Wed Nov 10 20:13:12 PST 2010


2010/11/11 Óscar Fuentes <ofv at wanadoo.es>:
>> At now, I have two-way patches.
>>
>> * 0001-llvm-LLVM_LIT_ARGS.patch
>> * 0001-clang-LLVM_LIT_ARGS.patch
>>
>> I got rid of separate_arguments(UNIX_COMMAND) but still I take
>> separate_arguments() to split whitespace-separated-STRING. It simply
>> must substitute space to semicolon.

> Okay, commit the version that uses the usual shell syntax
> (-DLLVM_LIT_ARGS="-s -v") Those parameters are for lit, not for cmake,
> and hence it is reasonable to use the same syntax that one would use if
> lit were invoked directly from the shell.

Committed in r118776 and r118777, thank you to advice me!




More information about the cfe-commits mailing list