[cfe-commits] r118629 - in /cfe/trunk: lib/Parse/ParseObjc.cpp test/Parser/missing-end-3.m

Fariborz Jahanian fjahanian at apple.com
Tue Nov 9 12:38:00 PST 2010


Author: fjahanian
Date: Tue Nov  9 14:38:00 2010
New Revision: 118629

URL: http://llvm.org/viewvc/llvm-project?rev=118629&view=rev
Log:
Issues good diagnostic when @end is missing.
// rdar://8283484

Added:
    cfe/trunk/test/Parser/missing-end-3.m
Modified:
    cfe/trunk/lib/Parse/ParseObjc.cpp

Modified: cfe/trunk/lib/Parse/ParseObjc.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseObjc.cpp?rev=118629&r1=118628&r2=118629&view=diff
==============================================================================
--- cfe/trunk/lib/Parse/ParseObjc.cpp (original)
+++ cfe/trunk/lib/Parse/ParseObjc.cpp Tue Nov  9 14:38:00 2010
@@ -404,6 +404,7 @@
       break;
         
     case tok::objc_implementation:
+    case tok::objc_interface:
       Diag(Tok, diag::err_objc_missing_end);
       ConsumeToken();
       break;

Added: cfe/trunk/test/Parser/missing-end-3.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/missing-end-3.m?rev=118629&view=auto
==============================================================================
--- cfe/trunk/test/Parser/missing-end-3.m (added)
+++ cfe/trunk/test/Parser/missing-end-3.m Tue Nov  9 14:38:00 2010
@@ -0,0 +1,10 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+// rdar://8283484
+ at interface blah {
+    @private
+}
+// since I forgot the @end here it should say something
+
+ at interface blah  // expected-error {{missing @end}}
+ at end // and Unknown type name 'end' here
+





More information about the cfe-commits mailing list