[cfe-commits] [Patch][Review Request]Fix for PR7287

Jim Goodnow II jim at thegoodnows.net
Mon Nov 1 14:51:28 PDT 2010


At 02:06 PM 11/1/2010, Douglas Gregor wrote:

>On Nov 1, 2010, at 1:59 PM, Jim Goodnow II wrote:
>
> > Hi,
> >
> > Please review and commit this patch for PR7287. Thanks.
>
>This isn't quite the right fix, because it won't handle, e.g., 
>direct calls to an operator
>
>         operator+(x, y)
>
>
>Instead, we should probably use FD->getIdentifier() and bail out 
>early if it returns NULL.
>
>         - Doug
>
> > - jim
> >

On the other hand, using getIdentifier() would be more general and 
handle other potential cases where there isn't a name. Are there such cases?

  - jim




More information about the cfe-commits mailing list