[cfe-commits] r116988 - /cfe/trunk/lib/Basic/Targets.cpp

[Anton Korobeynikov]

Hello Michael,

> +// Windows target
> +template<typename Target>
> +class WindowsTargetInfo : public OSTargetInfo<Target> {
> +protected:
> +  virtual void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple,
> +                            MacroBuilder &Builder) const {
> +    if (Opts.CPlusPlus) {
> +      if (Opts.RTTI)
> +        Builder.defineMacro("_CPPRTTI");
> +
> +      if (Opts.Exceptions)
> +        Builder.defineMacro("_CPPUNWIND");
All these includes are completely vcpp-specific. Windows TargetInfo
(as it was before) should be free of such stuff, please revert and
move everything to Visual Studio specific class (as it was before,
btw). Please don't forget that windows != vcpp.

Thanks.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University