[cfe-commits] [PATCH v2] Add Clang driver-support for directory-style precompiled headers

Sebastian Redl sebastian.redl at getdesigned.at
Fri Oct 15 10:44:31 PDT 2010


On 15.10.2010, at 19:06, Tor Arne Vestbø wrote:

> On 15.10.10 13.26, Sebastian Redl wrote:
>> Shouldn't we check for the existence of the file first, and only pass
>> -include-pch options if it does exist?
> 
> Oops, of course you're right :) New patch attached, with added test for that specific case.

Still doesn't feel right. Doesn't this now ignore the -include argument completely if it can find a PCH dir but not the right language? It should fall back to passing an -include argument, I believe.

Sebastian



More information about the cfe-commits mailing list