[cfe-commits] r116519 - in /cfe/trunk: lib/Sema/SemaObjCProperty.cpp test/SemaObjCXX/property-synthesis-error.mm

Fariborz Jahanian fjahanian at apple.com
Thu Oct 14 14:30:10 PDT 2010


Author: fjahanian
Date: Thu Oct 14 16:30:10 2010
New Revision: 116519

URL: http://llvm.org/viewvc/llvm-project?rev=116519&view=rev
Log:
Put line number on the diagnostic. //rdar: //8550657.


Added:
    cfe/trunk/test/SemaObjCXX/property-synthesis-error.mm
Modified:
    cfe/trunk/lib/Sema/SemaObjCProperty.cpp

Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaObjCProperty.cpp?rev=116519&r1=116518&r2=116519&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaObjCProperty.cpp (original)
+++ cfe/trunk/lib/Sema/SemaObjCProperty.cpp Thu Oct 14 16:30:10 2010
@@ -501,7 +501,7 @@
       ParmVarDecl *Param = (*P);
       Expr *rhs = new (Context) DeclRefExpr(Param,Param->getType(),
                                             SourceLocation());
-      ExprResult Res = BuildBinOp(S, SourceLocation(), 
+      ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 
                                   BO_Assign, lhs, rhs);
       PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>());
     }

Added: cfe/trunk/test/SemaObjCXX/property-synthesis-error.mm
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjCXX/property-synthesis-error.mm?rev=116519&view=auto
==============================================================================
--- cfe/trunk/test/SemaObjCXX/property-synthesis-error.mm (added)
+++ cfe/trunk/test/SemaObjCXX/property-synthesis-error.mm Thu Oct 14 16:30:10 2010
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+// rdar: //8550657
+
+ at interface NSArray @end
+
+ at interface NSMutableArray : NSArray @end
+
+ at interface MyClass
+{
+  NSMutableArray * _array;
+}
+
+ at property (readonly) NSArray * array;
+
+ at end
+
+ at interface MyClass ()
+
+ at property (readwrite) NSMutableArray * array;
+
+ at end
+
+ at implementation MyClass
+
+ at synthesize array=_array; // expected-error {{assigning to 'NSMutableArray *' from incompatible type 'NSArray *'}}
+
+ at end
+
+int main(void)
+{
+  return 0;
+}





More information about the cfe-commits mailing list