[cfe-commits] [patch] Add support for UCNs in character literals

Nico Weber thakis at chromium.org
Fri Oct 8 17:32:45 PDT 2010


(I got an ok to commit on irc.)

On Fri, Oct 8, 2010 at 5:26 PM, Nico Weber <thakis at chromium.org> wrote:
> D'oh, I attached the wrong patch file to my second post on this
> thread. Here's the right file. Sorry!
>
> On Fri, Oct 8, 2010 at 5:16 PM, Chris Lattner <clattner at apple.com> wrote:
>>
>> On Oct 7, 2010, at 10:50 PM, Nico Weber wrote:
>>
>>> Now with -triple line in the new file, so that this hopefully works on
>>> windows, too.
>>>
>>> For what it's worth, with this patch clang can build all of
>>> chromium/mac in debug mode.
>>
>> Hi Nico,
>>
>> The patch looks ok to me, but it would be better to factor with the existing code you added for string literals.  Is that reasonably possible?
>>
>> Thanks for working on this!
>>
>> -Chris
>>
>>
>




More information about the cfe-commits mailing list