[cfe-commits] [win32][review request] clang Index test fix

[NAKAMURA Takumi]

Francois,

On mingw, your patch improves test/Index/remap-load.c. Thanks!

test/Index/remap-complete works regardless of your patch.
I don't know why :p

FYI ...Takumi


2010/10/4 Francois Pichet <pichet2000 at gmail.com>:
> This patch remove the Win32 XFAIL from test/Index/remap-complete.c and
> test/Index/remap-load.c
>
> The problem was that text files were open in text mode and Microsoft
> implementation of fread and write will try to do nasty line-feed
> conversion which make the line position no longer valid.
>
> I think the option llvm::raw_fd_ostream::F_Binary should always be
> used. Or it should be removed and always applied. Or else we are going
> to have more problem with that.
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>