[cfe-commits] [PATCH] Add nested structs to the output of -ast-print-xml

[Douglas Gregor]

On Sep 29, 2010, at 9:16 AM, Daniel Dunbar wrote:

> Oops, I was just going through my backlog and thought this was ok (but
> don't know much about the XML dumping) and applied it in r115041.
> 
> Should I take it out again Doug?

It's not harmful, so it's okay if it stays in. Hopefully, to be replaced with what I described below :)

	- Doug

> - Daniel
> 
> On Wed, Sep 29, 2010 at 8:56 AM, Douglas Gregor <dgregor at apple.com> wrote:
>> 
>> On Sep 23, 2010, at 3:18 AM, Martin Vejnár wrote:
>> 
>>> Hi, the attached patch adds nested structures to the XML output. Only
>>> defined nested structures are added.
>> 
>> Why? It seems like addSubNodes() for a RecordDecl should just visit all of the nodes in the decls_begin()/decls_end(), printing everything (which will include fields, member functions, static data members, etc.). Of course, it could skip "implicit" declarations, so we don't have to see the injected-class-name.
>> 
>> With the restriction that only defined nested structures are added, we won't see forward-declared structures like
>> 
>>        struct X {
>>                struct Inner;
>>        };
>> 
>>        - Doug
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>