[cfe-commits] r113962 - in /cfe/trunk: include/clang/AST/ lib/AST/ lib/CodeGen/ lib/Sema/ test/CodeGenCXX/ test/SemaCXX/

Fariborz Jahanian fjahanian at apple.com
Wed Sep 15 13:43:42 PDT 2010


On Sep 15, 2010, at 1:40 PM, John McCall wrote:

>
> On Sep 15, 2010, at 1:32 PM, Fariborz Jahanian wrote:
>
>>
>> On Sep 15, 2010, at 3:17 AM, John McCall wrote:
>>
>>> Fixed log message:
>>>
>>> On Sep 15, 2010, at 3:14 AM, John McCall wrote:
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=113962&view=rev
>>>> Log:
>>>> Implement generalized copy elision.  The main obstacle here is that
>>>> IR-generation must be much more careful about making sure that  
>>>> exactly
>>>> one piece of code is responsible for the lifetime of every  
>>>> aggregate
>>>> slot.  The easiest way to do that was to bundle up the information
>>>> we care about for aggregate slots into a new structure which  
>>>> demands
>>>> that its creators at least consider the question.
>>>>
>>>> I could probably be convinced that the ObjC 'needs GC' bit should
>>>> be rolled into this structure.
>>
>> Makes sense to me. However bits 1 and 0 are already used up. Are you
>> OK with adding a bool:1 flag for it? If yes, I will work on it.
>
> Yeah, I don't have any objections to widening the structure.  If you  
> do, you
> might as well move the other flags to the new word.

Sounds good.

- Fariborz

>
>
> John.




More information about the cfe-commits mailing list