[cfe-commits] r113634 - /cfe/trunk/include/clang/AST/ExprCXX.h

Chris Lattner clattner at apple.com
Fri Sep 10 15:07:04 PDT 2010


On Sep 10, 2010, at 3:04 PM, Douglas Gregor wrote:

>> 
>> I don't see any reason to have tons of ivars that have trivial getters and setters, it's just a lot of redundant code.
> 
> Please don't. Having explicit getters makes it easier for us to tweak the internal representation (to save space, or keep track of more information, or whatever). In general, we shouldn't have setters [*], and serialization should just poke at the fields directly.
> 
> 	- Doug
> 
> [*] Most of these are my fault, since we're taking blame ;)

I'm fine with not "changing everything in the world" :)

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100910/94288f9b/attachment.html>


More information about the cfe-commits mailing list