[cfe-commits] r113015 - in /cfe/trunk: lib/CodeGen/CGExpr.cpp test/SemaCXX/blocks.cpp

[Fariborz Jahanian]

On Sep 3, 2010, at 2:48 PM, Douglas Gregor wrote:

>
> On Sep 3, 2010, at 2:36 PM, Fariborz Jahanian wrote:
>
>> Author: fjahanian
>> Date: Fri Sep  3 16:36:02 2010
>> New Revision: 113015
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=113015&view=rev
>> Log:
>> Cope with llvm's reference to bool type of 'i1' vs. clang's
>> type of 'i8' for the same for __block variables of
>> type bool. refixes radar 8382559.
>>
>> Modified:
>>   c
>
> I'm really uncomfortable with this change.  
> EmitExprForReferenceBinding needs to be doing the right thing for  
> block references of bool type, and adding this code here feels like  
> a workaround.
Thanks for the heads up. Problem, as we discussed was that we were not  
truncating the bool value of block variables (as we do for ordinary  
bool variables).
Fixed in http://llvm.org/viewvc/llvm-project?view=rev&revision=113027

- fariborz

>
>
> 	- Doug