[cfe-commits] [PATCH] Add Win64 var arg support

Cameron Esfahani dirty at apple.com
Tue Aug 31 03:25:36 PDT 2010


Here's even a betterer patch which fixes an alignment issue:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang_va.patch
Type: application/octet-stream
Size: 4115 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100831/9a87f0a5/attachment.obj>
-------------- next part --------------



Based on revision 112597.

On Aug 27, 2010, at 3:15 PM, Cameron Esfahani wrote:

> Here's better version which funnels the MingW64 and Cygwin X86_64 targets into the same ABIInfo as the Windows64 version.
> 
> Also, I removed a case for MingW64 in the 32-bit case.  It should have never been there...
> 
> <clang_va.patch>
> On Aug 27, 2010, at 2:57 PM, Anton Korobeynikov wrote:
> 
>> Hello Cameron,
>> 
>>> Win64 uses a different format for var args than the other x86_64 targets.  It's very similar to the Win32, so I started from there.
>> I don't this this is a proper solution.... E.g. mingw on win64 also
>> uses this ABI, so the code should be generalized somehow.
>> 
>> -- 
>> With best regards, Anton Korobeynikov
>> Faculty of Mathematics and Mechanics, Saint Petersburg State University
> 
> Cameron Esfahani
> dirty at apple.com
> 
> "There are times in the life of a nation when the only place a decent man can find himself is in prison."
> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Cameron Esfahani
dirty at apple.com

"You only live once, and the way I live, once is enough"

Frank Sinatra





More information about the cfe-commits mailing list