[cfe-commits] [PATCH] Implement member pointer support for the MS ABI in Sema

[Charles Davis]

Dang, forgot to attach the patch...
On 8/15/10 7:16 PM, Charles Davis wrote:
> On 8/15/10 12:24 AM, Charles Davis wrote:
>> On 8/15/10 12:20 AM, Sean Hunt wrote:
>>> On 08/15/2010 12:18 AM, Charles Davis wrote:
>>>> This patch gives member pointers the correct size when the Microsoft ABI
>>>> is active. This only implements the Sema/AST side (CodeGen coming soon).
>>>>
>>>> Chip
>>>
>>> Is it possible to make this a function of the ABI, rather than 
>>> hardcoding values into ASTContext?
>> Yeah, but we'd need an AST-side CXXABI object.
>>
>> I need to fix the patch anyway. In my haste, I forgot to test before
>> sending. :\
> Patch fixed. It adds this AST-side CXXABI object (and renames the
> CodeGen one to 'CGCXXABI' to avoid conflicts).
> 
> On 8/15/10 12:34 AM, Eli Friedman wrote:
>> It would be nice to add the appropriate warning about constructing a
>> member pointer to an incomplete type along with this... otherwise we
>> can end up silently generating bad code.
> It would be, but I don't know how to issue a diagnostic from the AST
> library, so I've left that out for now.
> 
> Chip

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ms-member-pointers.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100815/1c1cc666/attachment.ksh>