[cfe-commits] [PATCH] Make behavior of RecordLayoutBuilder overridable

[Sean Hunt]

On 08/14/2010 07:34 PM, Charles Davis wrote:
> On 8/14/10 1:55 PM, John McCall wrote:
>> This seems fine, though yeah, I guess I'd prefer that you checked it in with
>> the MS layout code.
> Here's a version that includes some MS-specific code. It handles the
> case where a class has both a virtual method and a virtual base (in such
> cases, VC would give it two virtual pointers).

Does every member function need to be virtual? A lot of those seem like 
overriding them is possibly a bad idea, and in any case it's not very 
useful to make them virtual if we aren't overriding them.

Sean