[cfe-commits] r108807 - in /cfe/trunk: include/clang/AST/ lib/AST/ lib/CodeGen/ lib/Frontend/ lib/Rewrite/ lib/Sema/

[Sebastian Redl]

On 07/19/2010 11:19 PM, Sean Hunt wrote:
>
>>   /// In C, implicit casts always produce rvalues. However, in C++, an
>>   /// implicit cast whose result is being bound to a reference will be
>> -/// an lvalue. For example:
>> +/// an lvalue or xvalue. For example:
>>     
> Should this say glvalue?
>   
It could, but I like this way better, since lvalue and xvalue are leaf
categories.
>   
>>   /// }
>>   /// @endcode
>>   class ImplicitCastExpr : public CastExpr {
>> -  /// LvalueCast - Whether this cast produces an lvalue.
>> -  bool LvalueCast;
>> +public:
>> +  enum ResultCategory {
>> +    RValue, LValue, XValue
>> +  };
>>     
> Why not PRValue?
>   
That's an oversight.

Sebastian