[cfe-commits] [patch] Implement support for @file

Daniel Dunbar daniel at zuster.org
Sun Jul 18 14:09:22 PDT 2010


Hi Rafael,

I would just move the SavedStrings and StringPointers arguments that
get used when CCC_ADD_ARGS or QA_OVERRIDE_GCC3_OPTIONS is set to
always being used. That would simplify that code so that there is only
one call to BuildCompilation, and then you can use SavedStrings to
capture the memory used in @file args.

 - Daniel

On Sat, Jul 17, 2010 at 7:15 PM, Rafael Espindola <espindola at google.com> wrote:
> The attached patch is a small update of the previous one that frees
> the memory. I also experimented with using std::string, but I would
> have to update a lot of interfaces to take std::string* instead of
> "const char **". Let me know if you would prefer that.
>
> Cheers,
> --
> Rafael Ávila de Espíndola
>




More information about the cfe-commits mailing list