[cfe-commits] r108220 - /cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[Devang Patel]

I did and it worked because 0x1 && 1 is fine. Thanks for catching this. Fixed. Added test case also.
-
Devang
On Jul 12, 2010, at 10:53 PM, Chris Lattner wrote:

> 
> On Jul 12, 2010, at 5:24 PM, Devang Patel wrote:
> 
>> Author: dpatel
>> Date: Mon Jul 12 19:24:30 2010
>> New Revision: 108220
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=108220&view=rev
>> Log:
>> const qualify debug info for "this" for const methods.
> 
> Did you test this Devang?  This should use & instead of &&.
> 
> -Chris
> 
>> 
>> Modified:
>>   cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
>> 
>> Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=108220&r1=108219&r2=108220&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Mon Jul 12 19:24:30 2010
>> @@ -536,6 +536,13 @@
>>    Context.getPointerType(Context.getTagDeclType(Method->getParent()));
>>  llvm::DIType ThisPtrType = 
>>    DebugFactory.CreateArtificialType(getOrCreateType(ThisPtr, Unit));
>> +
>> +  if (Method->getTypeQualifiers() && Qualifiers::Const)
>> +    ThisPtrType = 
>> +      DebugFactory.CreateDerivedType(llvm::dwarf::DW_TAG_const_type, 
>> +                                     Unit, "", Unit,
>> +                                     0, 0, 0, 0, 0, ThisPtrType);
>> +
>>  TypeCache[ThisPtr.getAsOpaquePtr()] = ThisPtrType;  
>>  Elts.push_back(ThisPtrType);
>> 
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>