[cfe-commits] r107541 - in /cfe/trunk: include/clang/AST/ExprCXX.h lib/Frontend/PCHReaderStmt.cpp lib/Frontend/PCHWriterStmt.cpp

Argyrios Kyrtzidis akyrtzi at gmail.com
Thu Jul 8 05:36:24 PDT 2010


Hi Enea,

On Thu, Jul 8, 2010 at 10:25 AM, Enea Zaffanella <zaffanella at cs.unipr.it>wrote:

> In the commit below the public method
>  CXXDefaultArgExpr::setUsedLocation()
> has been removed and friendship has been granted
> to PCH reader and writer.
>
> We were using setUsedLocation in our own code.
> Would it be OK if we restore it?
>

Sure! If I remove an AST method which I thought was in place only to support
PCH, feel free to restore it.

Just for clarification, the friendship has been granted because the PCH
reader is not safe to freely use the AST interfaces, I learned it the hard
way many times.

-Argiris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100708/ce3fec83/attachment.html>


More information about the cfe-commits mailing list