[cfe-commits] [PATCH] Limit the number of overload candidates printed (issue1591041)

jyasskin at gmail.com jyasskin at gmail.com
Mon Jun 7 18:03:30 PDT 2010


Reviewers: cfe-commits_cs.uiuc.edu,

Message:
Please take a look. If you prefer reviewing diffs, they're behind the
"Download raw patch set" link.

Description:
When there are lots of operator<<s, clang produces significantly worse
diagnostics than gcc, simply because of the size of the output. This
patch limits clang to 4 overload candidates, with the ability to show
the rest by passing -fshow-all-overloads, as a first cut. We'll want to
refine that later as examples of bad behavior come up.

Please review this at http://codereview.appspot.com/1591041/show

Affected files:
   M     include/clang/Basic/Diagnostic.h
   M     include/clang/Basic/DiagnosticSemaKinds.td
   M     include/clang/Driver/CC1Options.td
   M     include/clang/Driver/Options.td
   M     include/clang/Frontend/DiagnosticOptions.h
   M     lib/Basic/Diagnostic.cpp
   M     lib/Driver/Tools.cpp
   M     lib/Frontend/CompilerInvocation.cpp
   M     lib/Frontend/Warnings.cpp
   M     lib/Sema/SemaOverload.cpp
   M     test/SemaCXX/overload-call.cpp
   M     test/SemaCXX/overload-member-call.cpp
   M     test/SemaCXX/overloaded-builtin-operators.cpp
   M     test/SemaTemplate/constructor-template.cpp





More information about the cfe-commits mailing list