[cfe-commits] [PATCH] CallExprs returning references can be lvalues

[Ted Kremenek]

On Jun 2, 2010, at 9:48 PM, Zhongxing Xu wrote:

> Is it necessary to add all RHS of assignment expr as block-level expr?
> 
> +    return addStmt(B->getLHS(), AddStmtChoice::AsLValueNotAlwaysAdd);
> +  }
> 
> Here better to use visitStmt, because addStmt() means we want to 'add' the statement. Maybe we should modify some of the existing code to emphasize this.
>  
>  


That's right.  The rest of the cases in that method use addStmt() because they introduce real control-flow dependencies.  For the assignment operator this isn't need.

Zhongxing: I don't think any of the existing cases in that method need to be modified to use VisitStmt() instead of addStmt(), or do you see something?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100602/4d5cd4bb/attachment.html>