[cfe-commits] r104473 - in /cfe/trunk: lib/CodeGen/CGStmt.cpp test/CodeGenCXX/PR5863-unreachable-block.cpp

[Benjamin Kramer]

Author: d0k
Date: Sun May 23 15:57:46 2010
New Revision: 104473

URL: http://llvm.org/viewvc/llvm-project?rev=104473&view=rev
Log:
Add a comment for r104472.

Modified:
    cfe/trunk/lib/CodeGen/CGStmt.cpp
    cfe/trunk/test/CodeGenCXX/PR5863-unreachable-block.cpp

Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGStmt.cpp?rev=104473&r1=104472&r2=104473&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGStmt.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGStmt.cpp Sun May 23 15:57:46 2010
@@ -79,6 +79,9 @@
     // Expression emitters don't handle unreachable blocks yet, so look for one
     // explicitly here. This handles the common case of a call to a noreturn
     // function.
+    // We can't erase blocks with an associated cleanup size here since the
+    // memory might be reused, leaving the old cleanup info pointing at a new
+    // block.
     if (llvm::BasicBlock *CurBB = Builder.GetInsertBlock()) {
       if (CurBB->empty() && CurBB->use_empty() && !BlockScopes.count(CurBB)) {
         CurBB->eraseFromParent();

Modified: cfe/trunk/test/CodeGenCXX/PR5863-unreachable-block.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/PR5863-unreachable-block.cpp?rev=104473&r1=104472&r2=104473&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenCXX/PR5863-unreachable-block.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/PR5863-unreachable-block.cpp Sun May 23 15:57:46 2010
@@ -1,6 +1,6 @@
 // RUN: %clang_cc1 -emit-llvm-only %s
 
-// PR5836
+// PR5863
 class E { };
 
 void P1() {