[cfe-commits] [Request for approval] Added basic source locations to Elaborated and DependentName types.

[Abramo Bagnara]

Il 19/05/2010 01:29, John McCall ha scritto:
> 
>>>
>>> I notice that you didn't include the SourceRange for the NestedNameSpecifiers
>>> like I asked.  Without this, your calculation of the source ranges for these
>>> TypeLocs is incorrect, particularly because you're consistently assuming that
>>> KeywordLoc is a real source location — it's meaningless for ETK_None,
>>> which is possible for both ElaboratedType and DependentNameType.
>>>
>>> Please fix this.
>>
>> After some pain to fix some obscure details, we have revised the
>> reverted patch to add NestedNameSpecifiers location ranges and to fix
>> failures due to missing compilation of TemplateArgLocInfo.
>>
>> Please review the attached patch.
> 
> Looks good!  I only have two complaints.

I've attached the revised patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ElabTypeLoc-2.patch
Type: text/x-patch
Size: 26744 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100519/f01a4980/attachment.bin>