[cfe-commits] r101073 - in /cfe/trunk: lib/Parse/ParseExpr.cpp test/FixIt/fixit.c

Chris Lattner clattner at apple.com
Tue Apr 20 14:34:54 PDT 2010


On Apr 12, 2010, at 3:13 PM, Chris Lattner wrote:

> 
> On Apr 12, 2010, at 3:10 PM, Ted Kremenek wrote:
> 
>> Author: kremenek
>> Date: Mon Apr 12 17:10:35 2010
>> New Revision: 101073
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=101073&view=rev
>> Log:
>> Add fixit hint for missing ':' in ternary expressions.
> 
> Nice!  One refinement: fixit hints should recover as if they saw the expected thing.  In this case, it means that the 'return ExprError' shouldn't happen, maybe a : could be injected into the token stream?

I fixed this for you in r101943.

-Chris





More information about the cfe-commits mailing list