[cfe-commits] multifile fixits

Douglas Gregor dgregor at apple.com
Wed Apr 14 16:26:19 PDT 2010


On Apr 14, 2010, at 4:19 PM, Chris Lattner wrote:

> 
> On Apr 14, 2010, at 7:44 AM, Douglas Gregor wrote:
> 
>> Thanks for maintaining the current interface. Now, I think we should change that interface :)
>> 
>> The "only fix the main file" approach was me being paranoid when fix-its first went it. I think the right answer now is for -fixit to always apply changes to all of the files (in place)
> 
> One thing to worry about here is parallel builds where multiple compiler instances try to fix the same error in a shared header.


Yup. We should at least detect when this has happened and, perhaps, check whether the contents of the already-fixed header match what we were going to write.

	- Doug



More information about the cfe-commits mailing list