[cfe-commits] multifile fixits

Nick Lewycky nlewycky at google.com
Fri Apr 9 19:24:25 PDT 2010


Currently the fixit system runs in one of two modes, either fix the
particular problems specified through the -fixit-at parameter, or fix only
the problems found in the main file. As a bonus bug, in the fix-all mode,
clang's diagnostic output will claim that it's applied changes to files that
it isn't actually touching.

This patch makes fixits apply to all files when no -fixit-at or -o flag is
specified. For compatibility with our tests, clang -fixit -o foo will still
only output the main file (but see FIXME in patch). This also exposes the
fileid's out the FixItRewriter so that users can write their own frontend
action which chooses file names other than the default foo.fixit.cc.

Finally, this uncovered PR6813 in case you're wondering what the 3 xfailed
tests are about.

Please review!

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100409/e14d0a04/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-multifile-fixit.patch
Type: text/x-patch
Size: 14639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100409/e14d0a04/attachment.bin>


More information about the cfe-commits mailing list