[cfe-commits] More on templates and vtables

Rafael Espindola espindola at google.com
Wed Mar 24 05:28:05 PDT 2010


> I'm not too thrilled about the code that checks whether implicit copy assignment is legal; we have very similar code in elsewhere (e.g., Sema::DefineImplicitOverloadedAssign), and it would be unfortunate to have to keep these in sync...

I am not thrilled either. Do you have a suggestion on how to factor
this? I thought about adding a boolean argument (defaulting to false)
to Sema::DefineImplicitOverloadedAssign to suppress errors if it
couldn't create the function.

> also, if we have to do this for copy-assignment, wouldn't we have to do this for all of the implicit special member functions?

Not sure if that is correct, but clang will happily create implicit
constructor, destructor and copy constructor for classes with members
that are const qualified or references.

>        - Doug


Cheers,
-- 
Rafael Ávila de Espíndola




More information about the cfe-commits mailing list