[cfe-commits] r99317 - in /cfe/trunk: lib/CodeGen/CGVtable.cpp lib/CodeGen/CodeGenModule.cpp lib/Sema/SemaTemplate.cpp test/CodeGenCXX/PR6677.cpp

[Rafael Espindola]

Author: rafael
Date: Tue Mar 23 14:55:22 2010
New Revision: 99317

URL: http://llvm.org/viewvc/llvm-project?rev=99317&view=rev
Log:
revert 99311. Looks like it broke darwin bootstrap.


Modified:
    cfe/trunk/lib/CodeGen/CGVtable.cpp
    cfe/trunk/lib/CodeGen/CodeGenModule.cpp
    cfe/trunk/lib/Sema/SemaTemplate.cpp
    cfe/trunk/test/CodeGenCXX/PR6677.cpp

Modified: cfe/trunk/lib/CodeGen/CGVtable.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGVtable.cpp?rev=99317&r1=99316&r2=99317&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGVtable.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGVtable.cpp Tue Mar 23 14:55:22 2010
@@ -3805,17 +3805,7 @@
     return;
 
   TemplateSpecializationKind kind = RD->getTemplateSpecializationKind();
-
-
-  // The reason we have TSK_ExplicitInstantiationDeclaration in here (but not
-  // in  Sema::MaybeMarkVirtualMembersReferenced) is for the case
-  // template<> void stdio_sync_filebuf<wchar_t>::xsgetn() {
-  // }
-  // extern template class stdio_sync_filebuf<wchar_t>;
-  // Since we are called after the extern declaration is seen.
-
-  if (kind == TSK_ImplicitInstantiation ||
-      kind == TSK_ExplicitInstantiationDeclaration)
+  if (kind == TSK_ImplicitInstantiation)
     CGM.DeferredVtables.push_back(RD);
   else
     GenerateClassData(CGM.getVtableLinkage(RD), RD);

Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=99317&r1=99316&r2=99317&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Tue Mar 23 14:55:22 2010
@@ -310,17 +310,8 @@
   //   instantiated when used so that the body can be considered for 
   //   inlining, but that no out-of-line copy of the inline function would be
   //   generated in the translation unit. -- end note ]
-
-  // We check the specialization kind of the class for implicit methods.
-  // They have a TSK_Undeclared specialization kind.
-  TemplateSpecializationKind TSK;
-  const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD);
-  if (MD && MD->isImplicit())
-    TSK = MD->getParent()->getTemplateSpecializationKind();
-  else
-    TSK = FD->getTemplateSpecializationKind();
-
-  if (TSK == TSK_ExplicitInstantiationDeclaration)
+  if (FD->getTemplateSpecializationKind() 
+                                       == TSK_ExplicitInstantiationDeclaration)
     return CodeGenModule::GVA_C99Inline;
   
   return CodeGenModule::GVA_CXXInline;

Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaTemplate.cpp?rev=99317&r1=99316&r2=99317&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaTemplate.cpp (original)
+++ cfe/trunk/lib/Sema/SemaTemplate.cpp Tue Mar 23 14:55:22 2010
@@ -4389,7 +4389,13 @@
   Def = cast_or_null<ClassTemplateSpecializationDecl>(
                                        Specialization->getDefinition());
   if (Def) {
-    Def->setTemplateSpecializationKind(TSK);
+    TemplateSpecializationKind Old_TSK = Def->getTemplateSpecializationKind();
+
+    // Fix a TSK_ExplicitInstantiationDeclaration followed by a
+    // TSK_ExplicitInstantiationDefinition
+    if (Old_TSK == TSK_ExplicitInstantiationDeclaration &&
+        TSK == TSK_ExplicitInstantiationDefinition)
+      Def->setTemplateSpecializationKind(TSK);
 
     InstantiateClassTemplateSpecializationMembers(TemplateNameLoc, Def, TSK);
   }

Modified: cfe/trunk/test/CodeGenCXX/PR6677.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/PR6677.cpp?rev=99317&r1=99316&r2=99317&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenCXX/PR6677.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/PR6677.cpp Tue Mar 23 14:55:22 2010
@@ -3,9 +3,6 @@
 // CHECK-NOT: @_ZTVN5test118stdio_sync_filebufIwEE = constant
 // CHECK: @_ZTVN5test018stdio_sync_filebufIwEE = constant
 
-// CHECK: define linkonce_odr void @_ZN5test21CIiE5fobarIdEEvT_
-// CHECK: define available_externally void @_ZN5test21CIiE6zedbarEd
-
 namespace test0 {
   struct  basic_streambuf   {
     virtual       ~basic_streambuf();
@@ -16,12 +13,7 @@
   };
 
   // This specialization should cause the vtable to be emitted, even with
-  // the following extern template declaration (test at the top).
-
-  // The existance of the extern template declaration should prevent us from emitting
-  // destructors.
-  // CHECK: define available_externally void @_ZN5test018stdio_sync_filebufIwED0Ev
-  // CHECK: define available_externally void @_ZN5test018stdio_sync_filebufIwED2Ev
+  // the following extern template declaration.
   template<> void stdio_sync_filebuf<wchar_t>::xsgetn()  {
   }
   extern template class stdio_sync_filebuf<wchar_t>;
@@ -36,30 +28,6 @@
     virtual void      xsgetn();
   };
 
-  // Just a declaration should not force the vtable to be emitted
-  // (test at the top).
+  // Just a declaration should not force the vtable to be emitted.
   template<> void stdio_sync_filebuf<wchar_t>::xsgetn();
 }
-
-namespace test2 {
-  template<typename T1>
-  class C {
-    void zedbar(double) {
-    }
-    template<typename T2>
-    void fobar(T2 foo) {
-    }
-  };
-  extern template class C<int>;
-  void g() {
-    C<int> a;
-    // The extern template declaration should not prevent us from producing
-    /// foobar.
-    // (test at the top).
-    a.fobar(0.0);
-
-    // But it should prevent zebbar
-    // (test at the top).
-    a.zedbar(0.0);
-  }
-}