[cfe-commits] [patch] Fix PR6353 and some related issues

Douglas Gregor dgregor at apple.com
Tue Mar 2 12:07:55 PST 2010


On Mar 2, 2010, at 11:44 AM, Rafael Espindola wrote:

>> I'd rather the code be in Sema::SetBaseOrMemberInitializers.
> 
> A new patch is attached. One thing I could not change is
> 
> case TSK_ExplicitInstantiationDeclaration:
>       return false;
> 
> If I do that we fail on
> 
> ----------------------------------------------
> class Option {
> virtual ~Option() {
> }
> };
> template <class DataType> class opt : public Option {
> virtual bool handleOccurrence() {
> }
> };
> __extension__ extern template class opt<unsigned>;
> template class opt<unsigned>;
> ----------------------------------------------
> 
> Do you think the patch is an improvement as is? I will be out most of
> the rest of the week, so the sooner this is in the sooner we can track
> what else is broken for bootstraping on ELF.

Yes, this patch is an improvement; feel free to commit.

Are we still failing bootstrap on ELF systems, even with this patch?

	- Doug



More information about the cfe-commits mailing list