[cfe-commits] [patch] Add support for weakref

Rafael Espindola espindola at google.com
Mon Feb 22 13:42:03 PST 2010


> I would rather have WeakRefAttr in the AST, so we model the source more closely. Codegen can just handle it the same way as "weak" or "alias weak", depending on whether the "alias" attribute is also present.
>
> Otherwise, this looks fine to me, but I admit that I don't have a solid understanding of weakref.

It is fuzzy for me too. I am mostly trying to do what llvm-gcc does.

I have update the patch to add a WeakRefAttr. I have also updated it
to be more strict about what it accepts. It will now reject a weakref
with a missing target. We can add that back if it is actually used.

>        - Doug

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: weakref.patch
Type: text/x-patch
Size: 9123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100222/f069733f/attachment.bin>


More information about the cfe-commits mailing list