[cfe-commits] r94704 - /cfe/trunk/lib/Analysis/PrintfFormatString.cpp

Ted Kremenek kremenek at apple.com
Wed Jan 27 16:02:05 PST 2010


Author: kremenek
Date: Wed Jan 27 18:02:05 2010
New Revision: 94704

URL: http://llvm.org/viewvc/llvm-project?rev=94704&view=rev
Log:
Add a few more conversion specifiers to ParseFormatSpecifier (these appear in SemaChecking).

Modified:
    cfe/trunk/lib/Analysis/PrintfFormatString.cpp

Modified: cfe/trunk/lib/Analysis/PrintfFormatString.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/PrintfFormatString.cpp?rev=94704&r1=94703&r2=94704&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/PrintfFormatString.cpp (original)
+++ cfe/trunk/lib/Analysis/PrintfFormatString.cpp Wed Jan 27 18:02:05 2010
@@ -85,7 +85,7 @@
                                                   const char *&Beg, const char *E) {
   
   const char *I = Beg;
-  const char *Start = NULL;
+  const char *Start = 0;
   UpdateOnReturn <const char*> UpdateBeg(Beg, I);
 
   // Look for a '%' character that indicates the start of a format specifier.
@@ -191,28 +191,35 @@
   // Finally, look for the conversion specifier.
   ConversionSpecifier::Kind cs;
   switch (*I) {
+    case 'D':
+    case 'O':
+    case 'U':
+    case 'C':
+    case 'S':
     default:
       H.HandleInvalidConversionSpecifier(I);
       return true;
-    case 'd' : cs = ConversionSpecifier::dArg; break;
-    case 'i' : cs = ConversionSpecifier::iArg; break;
-    case 'o' : cs = ConversionSpecifier::oArg; break;
-    case 'u' : cs = ConversionSpecifier::uArg; break;
-    case 'x' : cs = ConversionSpecifier::xArg; break;
-    case 'X' : cs = ConversionSpecifier::XArg; break;
-    case 'f' : cs = ConversionSpecifier::fArg; break;
-    case 'F' : cs = ConversionSpecifier::FArg; break;
-    case 'e' : cs = ConversionSpecifier::eArg; break;
-    case 'E' : cs = ConversionSpecifier::EArg; break;
-    case 'g' : cs = ConversionSpecifier::gArg; break;
-    case 'G' : cs = ConversionSpecifier::GArg; break;
-    case 'a' : cs = ConversionSpecifier::aArg; break;
-    case 'A' : cs = ConversionSpecifier::AArg; break;
-    case 'c' : cs = ConversionSpecifier::IntAsCharArg; break;
-    case 's' : cs = ConversionSpecifier::CStrArg;      break;
-    case 'p' : cs = ConversionSpecifier::VoidPtrArg;   break;
-    case 'n' : cs = ConversionSpecifier::OutIntPtrArg; break;
-    case '%' : cs = ConversionSpecifier::PercentArg;   break;
+      
+    // Handle the cases we know about.
+    case 'd': cs = ConversionSpecifier::dArg; break;
+    case 'i': cs = ConversionSpecifier::iArg; break;
+    case 'o': cs = ConversionSpecifier::oArg; break;
+    case 'u': cs = ConversionSpecifier::uArg; break;
+    case 'x': cs = ConversionSpecifier::xArg; break;
+    case 'X': cs = ConversionSpecifier::XArg; break;
+    case 'f': cs = ConversionSpecifier::fArg; break;
+    case 'F': cs = ConversionSpecifier::FArg; break;
+    case 'e': cs = ConversionSpecifier::eArg; break;
+    case 'E': cs = ConversionSpecifier::EArg; break;
+    case 'g': cs = ConversionSpecifier::gArg; break;
+    case 'G': cs = ConversionSpecifier::GArg; break;
+    case 'a': cs = ConversionSpecifier::aArg; break;
+    case 'A': cs = ConversionSpecifier::AArg; break;
+    case 'c': cs = ConversionSpecifier::IntAsCharArg; break;
+    case 's': cs = ConversionSpecifier::CStrArg;      break;
+    case 'p': cs = ConversionSpecifier::VoidPtrArg;   break;
+    case 'n': cs = ConversionSpecifier::OutIntPtrArg; break;
+    case '%': cs = ConversionSpecifier::PercentArg;   break;
   }
   FS.setConversionSpecifier(cs);
   return FormatSpecifierResult(Start, FS);





More information about the cfe-commits mailing list