[cfe-commits] [Review] Rolling out ASTContext::getTypeSizeInChars()

[Ted Kremenek]

Hi Ken,

Thanks for tackling this.  I looked at the changes to libAnalysis, and noticed the following line:

+    amt = CharUnits::fromRaw(getContext().getTypeAlign(T) / 8);

Does it make since to have a matching getTypeAlignInChars() as well?  That would make the line:

 amt = getContext.getTypeAlignInChars();

I'm also concerned about the dimensionality here.  Why did we choose 'Chars' instead of 'Bytes'?

Ted

On Jan 4, 2010, at 11:08 AM, Ken Dyck wrote:

> 
> The attached patches replace occurrences of ASTContext::getTypeSize()/8
> with ASTContext::getTypeSizeInChars(),  converting [u]int64_t variables
> to CharUnits ones where it seems appropriate. No functional changes are
> intended. The changes touch the AST, Analysis, Sema, and CodeGen
> libraries and are split into patches accordingly.
> 
> Comments appreciated.
> 
> -Ken
> 
> <GetTypeSizeInChars-Sema.patch><GetTypeSizeInChars-Analysis.patch><GetTypeSizeInChars-AST.patch><GetTypeSizeInChars-CodeGen.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits