[cfe-commits] [PING^2] Handling of target attributes

Chris Lattner clattner at apple.com
Sat Jan 9 14:37:33 PST 2010

On Jan 9, 2010, at 2:22 PM, Anton Korobeynikov wrote:

> Hi, Chris
>> This is great stuff, hopefully dllimport/export can be converted as well.
> Not directly, since it has some weird decl merging rules. I haven't
> thought about it deeply though :)
>> Otherwise, the patch looks pretty good to me.
>> Please resent out another version of it with the file rename,
>> so I can review the TargetABIInfo.cpp changes, thanks!
> Here is it.

Thanks! Much smaller.  Please also commit the rename before you commit this patch.

+//===---- TargetInfo.h - Encapsulate target details -------------*- C++ -*-===//

+#include <cstdlib>

Please remove this by using 0 instead of NULL.

+  class TargetCodeGenInfo {

Please add doxygen comments.

+    ABIInfo* Info;
+  public:
+    TargetCodeGenInfo(ABIInfo* info = NULL):Info(info) { };

*'s are in the wrong places.  Please add a *big* comment to the constructor saying that it takes ownership of the ABIInfo object.

After you take care of these and the previous feedback, please apply.  Thanks Anton!


More information about the cfe-commits mailing list