[cfe-commits] [Review] Rolling out ASTContext::getTypeSizeInChars()

Chris Lattner clattner at apple.com
Sat Jan 9 14:05:25 PST 2010

On Jan 4, 2010, at 11:08 AM, Ken Dyck wrote:

> The attached patches replace occurrences of ASTContext::getTypeSize()/8
> with ASTContext::getTypeSizeInChars(),  converting [u]int64_t variables
> to CharUnits ones where it seems appropriate. No functional changes are
> intended. The changes touch the AST, Analysis, Sema, and CodeGen
> libraries and are split into patches accordingly.

Sorry for the delay, this code looks great to me.  The only thing that I don't like is the name 'getRaw()'.  How about just 'getValue()' or getAmount()?


More information about the cfe-commits mailing list