[cfe-commits] r92911 - in /cfe/trunk: lib/CodeGen/Mangle.cpp test/CodeGenCXX/mangle.cpp

[Sean Hunt]

On 01/07/2010 04:59 PM, Nuno Lopes wrote:
> Nops. I just notice a patch from Sean Hunt on the mailing list to fix that
> bug. I can take a look at it tomorrow or at worst during the weekend.
> Nuno

My patch's behavior is more similar to GCC's, I believe. Your patch will 
mangle "foo::i" as _ZLN3fooE1i; my patch and GCC will mangle it as 
_ZN3fooEL1i (in your case, the L is right after the Z, in mine it is 
prior to the "1i"). Mine also implements the change that internal 
variables are always mangled, even in the global namespace, which is 
required to avoid the source of the bug.

As far as I know I don't yet have permission to commit unreviewed, so I 
can't commit the patch yet.

Sean