[cfe-commits] r91210 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/SemaCXX/offsetof.cpp test/SemaCXX/vararg-non-pod.cpp

[Douglas Gregor]

On Dec 17, 2009, at 12:11 PM, Chris Lattner wrote:

>
> On Dec 11, 2009, at 11:25 PM, Douglas Gregor wrote:
>
>> Author: dgregor
>> Date: Sat Dec 12 01:25:49 2009
>> New Revision: 91210
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=91210&view=rev
>> Log:
>> Suppress warnings and errors about certain uses of non-POD types (in
>> __builtin_offsetof, passing through an ellipsis) when we're in an
>> unevaluated context. This is the first part of the fix to PR5761,
>> which deals with the simple case of an unevaluated context.
>
> Thanks Doug, I feel bad turning this into an error :).
>
> However, it seems bad to duplicate this switch like this into each  
> place that wants to emit a "runtime error".  Would it make sense for  
> the individual diagnostic producing cases to make a partial  
> diagnostic and pass it into code that either ignores it, emits it,  
> or buffers it?

Yep, good idea. Added Sema::DiagRuntimeBehavior in r91870. Thanks!

	- Doug