[cfe-commits] r91382 - /cfe/trunk/lib/CodeGen/CGExpr.cpp

[Chris Lattner]

On Dec 14, 2009, at 4:59 PM, Mike Stump wrote:

> Author: mrs
> Date: Mon Dec 14 18:59:40 2009
> New Revision: 91382
>
> URL: http://llvm.org/viewvc/llvm-project?rev=91382&view=rev
> Log:
> Ensure we preserve line information for each  trap for
> -fcatch-undefined-behavior if we aren't optimizing.  WIP.

Thanks Mike:
>
> llvm::BasicBlock*CodeGenFunction::getTrapBB() {

Please add a space before the *, that looks like a multiply to me :)

-Chris

> -  if (TrapBB)
> +  const CodeGenOptions &GCO = CGM.getCodeGenOpts();
> +
> +  // If we are not optimzing, don't collapse all calls to trap in  
> the function
> +  // to the same call, that way, in the debugger they can see which  
> operation
> +  // did in fact fail.  If we are optimizing, we collpase all call  
> to trap down
> +  // to just one per function to save on codesize.
> +  if (GCO.OptimizationLevel
> +      && TrapBB)
>     return TrapBB;
>
>   llvm::BasicBlock *Cont = 0;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits