[cfe-commits] r90907 - /cfe/trunk/test/Preprocessor/dump_macros.c

[Chris Lattner]

On Dec 8, 2009, at 10:36 PM, Daniel Dunbar wrote:

> On Tue, Dec 8, 2009 at 5:07 PM, Chris Lattner <clattner at apple.com> wrote:
>> 
>> On Dec 8, 2009, at 4:04 PM, Daniel Dunbar wrote:
>> 
>>> Author: ddunbar
>>> Date: Tue Dec  8 18:04:46 2009
>>> New Revision: 90907
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=90907&view=rev
>>> Log:
>>> Improve test portability; I can't figure out how to get the regexp library
>>> to
>>> match $ correctly with \r\n, unfortunately.
>> 
>> Why is it getting \r\n?  It sounds like the real problem is that filecheck
>> is opening the memory buffer as ascii instead of binary?
> 
> The output of clang has \r\n in it, which is correct, because it is
> writing text output. I thought perhaps FileCheck could still normalize
> \r\n in strict-whitespace mode, but if its only one test case...

Ah ok, this is fine then.  Thanks,

-Chris