[cfe-commits] r90642 - in /cfe/trunk: include/clang/Basic/Diagnostic.h lib/Basic/Diagnostic.cpp lib/Frontend/TextDiagnosticPrinter.cpp tools/clang-cc/clang-cc.cpp

[steve naroff]

On Dec 4, 2009, at 10:37 PM, Daniel Dunbar wrote:

> On Fri, Dec 4, 2009 at 6:36 PM, steve naroff <snaroff at apple.com>  
> wrote:
>>
>> On Dec 4, 2009, at 9:27 PM, Eli Friedman wrote:
>>
>>> On Fri, Dec 4, 2009 at 6:14 PM, Steve Naroff <snaroff at apple.com>
>>> wrote:
>>>> --- cfe/trunk/include/clang/Basic/Diagnostic.h (original)
>>>> +++ cfe/trunk/include/clang/Basic/Diagnostic.h Fri Dec  4 20:14:08
>>>> 2009
>>>> @@ -182,6 +182,7 @@
>>>>   bool SuppressAllDiagnostics;   // Suppress all diagnostics.
>>>>   ExtensionHandling ExtBehavior; // Map extensions onto warnings or
>>>> errors?
>>>>   DiagnosticClient *Client;
>>>> +  LangOptions *LangOpts;
>>>>
>>>>   /// DiagMappings - Mapping information for diagnostics.  Mapping
>>>> info is
>>>>   /// packed into four bits per diagnostic.  The low three bits are
>>>> the mapping
>>>> @@ -238,7 +239,9 @@
>>>>   DiagnosticClient *getClient() { return Client; }
>>>>   const DiagnosticClient *getClient() const { return Client; }
>>>>
>>>> -
>>>> +  LangOptions *getLangOpts() const { return LangOpts; }
>>>> +  void setLangOpts(LangOptions *LOpts) { LangOpts = LOpts; }
>>>> +
>>>>   /// pushMappings - Copies the current DiagMappings and pushes the
>>>> new copy
>>>>   /// onto the top of the stack.
>>>>   void pushMappings();
>>>
>>> It would be better to have an option in DiagnosticOptions instead
>>> making the diagnostic printer mess with the LangOptions directly.
>>>
>>
>> That's fine with me (the branch I was working on didn't have
>> DiagnosticOptions).
>>
>> Since this works, I'll clean this up later (after my other unrelated
>> changes have been integrated).
>
> Ok, but please don't forget -- we really don't want this extra  
> dependency.
>
> Also not that this is causing the message-length.c test to fail on
> Windows, that should probably be fixed by moving that test to use
> clang-cc, although I didn't look closely.
>

Fixed in http://llvm.org/viewvc/llvm-project?view=rev&revision=90664.

Sorry for the confusion...

snaroff

> - Daniel
>
>> snaroff
>>
>>> -Eli
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>