[cfe-commits] [PATCH] Emit returned aggregates directly into sret slot when applicable

Mike Stump mrs at apple.com
Thu Dec 3 08:51:19 PST 2009


On Dec 2, 2009, at 10:59 PM, Eli Friedman wrote:
> Patch attached.  This seems blindingly obvious, but since it hasn't
> been done yet, I have a feeling I'm missing something.

What happens when CurFnInfo->getReturnInfo().getKind() ==  
ABIArgInfo::Indirect is false and hasAggregateLLVMType(CurFnInfo- 
 >getReturnType())) is true?  I'm thinking that might be a can't  
happen scenario, but if so, it should just assert CurFnInfo- 
 >getReturnInfo().getKind() == ABIArgInfo::Indirect, right?

Aside from this, I think this is safe...



More information about the cfe-commits mailing list