[cfe-commits] r89655 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaStmt.cpp test/FixIt/fixit-cxx0x.cpp test/SemaCXX/switch-0x.cpp test/SemaCXX/switch.cpp

[Chris Lattner]

On Nov 24, 2009, at 9:05 PM, Douglas Gregor wrote:

> 
> On Nov 23, 2009, at 9:19 AM, Chris Lattner wrote:
> 
>> 
>> On Nov 23, 2009, at 5:46 AM, Douglas Gregor wrote:
>> 
>>> Author: dgregor
>>> Date: Mon Nov 23 07:46:08 2009
>>> New Revision: 89655
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=89655&view=rev
>>> Log:
>>> Implement conversion from a switch condition with class type to an
>>> integral or enumeration type (vi user-defined conversions). Fixes PR5518.
>> 
>> Hi Doug,
>> 
>> Is it possible to pull the "c++ case" out of ActOnStartOfSwitchStmt into a static helper method?  This would reduce indentation and make the code much easier to follow.
> 
> Sure, it's here:
> 
> 	http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20091123/024372.html
> 	http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20091123/024373.html
> 
>> It would even be nice to only call into the function when you have a "non-trivial" switch condition in C++ mode (i.e. not integer or enum)
> 
> It seemed to flow more nicely if I didn't do this.

Thanks!

-Chris