[cfe-commits] r90043 - in /cfe/trunk/lib/AST: DeclPrinter.cpp ExprConstant.cpp StmtDumper.cpp StmtPrinter.cpp StmtProfile.cpp

[Ted Kremenek]

Hi Ben,

I probably missed the relevant thread, but what is the motivation for this change?

On Nov 28, 2009, at 11:03 AM, Benjamin Kramer wrote:

> Author: d0k
> Date: Sat Nov 28 13:03:38 2009
> New Revision: 90043
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=90043&view=rev
> Log:
> Remove VISIBILITY_HIDDEN from lib/AST.
> 
> Modified:
>    cfe/trunk/lib/AST/DeclPrinter.cpp
>    cfe/trunk/lib/AST/ExprConstant.cpp
>    cfe/trunk/lib/AST/StmtDumper.cpp
>    cfe/trunk/lib/AST/StmtPrinter.cpp
>    cfe/trunk/lib/AST/StmtProfile.cpp
> 
> Modified: cfe/trunk/lib/AST/DeclPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DeclPrinter.cpp?rev=90043&r1=90042&r2=90043&view=diff
> 
> ==============================================================================
> --- cfe/trunk/lib/AST/DeclPrinter.cpp (original)
> +++ cfe/trunk/lib/AST/DeclPrinter.cpp Sat Nov 28 13:03:38 2009
> @@ -18,13 +18,11 @@
> #include "clang/AST/DeclObjC.h"
> #include "clang/AST/Expr.h"
> #include "clang/AST/PrettyPrinter.h"
> -#include "llvm/Support/Compiler.h"
> -#include "llvm/Support/Format.h"
> #include "llvm/Support/raw_ostream.h"
> using namespace clang;
> 
> namespace {
> -  class VISIBILITY_HIDDEN DeclPrinter : public DeclVisitor<DeclPrinter> {
> +  class DeclPrinter : public DeclVisitor<DeclPrinter> {
>     llvm::raw_ostream &Out;
>     ASTContext &Context;
>     PrintingPolicy Policy;
> 
> Modified: cfe/trunk/lib/AST/ExprConstant.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ExprConstant.cpp?rev=90043&r1=90042&r2=90043&view=diff
> 
> ==============================================================================
> --- cfe/trunk/lib/AST/ExprConstant.cpp (original)
> +++ cfe/trunk/lib/AST/ExprConstant.cpp Sat Nov 28 13:03:38 2009
> @@ -19,7 +19,6 @@
> #include "clang/Basic/Builtins.h"
> #include "clang/Basic/TargetInfo.h"
> #include "llvm/ADT/SmallString.h"
> -#include "llvm/Support/Compiler.h"
> #include <cstring>
> 
> using namespace clang;
> @@ -153,7 +152,7 @@
> }
> 
> namespace {
> -class VISIBILITY_HIDDEN HasSideEffect
> +class HasSideEffect
>   : public StmtVisitor<HasSideEffect, bool> {
>   EvalInfo &Info;
> public:
> @@ -210,7 +209,7 @@
> // LValue Evaluation
> //===----------------------------------------------------------------------===//
> namespace {
> -class VISIBILITY_HIDDEN LValueExprEvaluator
> +class LValueExprEvaluator
>   : public StmtVisitor<LValueExprEvaluator, APValue> {
>   EvalInfo &Info;
> public:
> @@ -353,7 +352,7 @@
> //===----------------------------------------------------------------------===//
> 
> namespace {
> -class VISIBILITY_HIDDEN PointerExprEvaluator
> +class PointerExprEvaluator
>   : public StmtVisitor<PointerExprEvaluator, APValue> {
>   EvalInfo &Info;
> public:
> @@ -508,7 +507,7 @@
> //===----------------------------------------------------------------------===//
> 
> namespace {
> -  class VISIBILITY_HIDDEN VectorExprEvaluator
> +  class VectorExprEvaluator
>   : public StmtVisitor<VectorExprEvaluator, APValue> {
>     EvalInfo &Info;
>     APValue GetZeroVector(QualType VecType);
> @@ -702,7 +701,7 @@
> //===----------------------------------------------------------------------===//
> 
> namespace {
> -class VISIBILITY_HIDDEN IntExprEvaluator
> +class IntExprEvaluator
>   : public StmtVisitor<IntExprEvaluator, bool> {
>   EvalInfo &Info;
>   APValue &Result;
> @@ -1487,7 +1486,7 @@
> //===----------------------------------------------------------------------===//
> 
> namespace {
> -class VISIBILITY_HIDDEN FloatExprEvaluator
> +class FloatExprEvaluator
>   : public StmtVisitor<FloatExprEvaluator, bool> {
>   EvalInfo &Info;
>   APFloat &Result;
> @@ -1679,7 +1678,7 @@
> //===----------------------------------------------------------------------===//
> 
> namespace {
> -class VISIBILITY_HIDDEN ComplexExprEvaluator
> +class ComplexExprEvaluator
>   : public StmtVisitor<ComplexExprEvaluator, APValue> {
>   EvalInfo &Info;
> 
> 
> Modified: cfe/trunk/lib/AST/StmtDumper.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/StmtDumper.cpp?rev=90043&r1=90042&r2=90043&view=diff
> 
> ==============================================================================
> --- cfe/trunk/lib/AST/StmtDumper.cpp (original)
> +++ cfe/trunk/lib/AST/StmtDumper.cpp Sat Nov 28 13:03:38 2009
> @@ -17,7 +17,6 @@
> #include "clang/AST/DeclCXX.h"
> #include "clang/AST/PrettyPrinter.h"
> #include "clang/Basic/SourceManager.h"
> -#include "llvm/Support/Compiler.h"
> #include <cstdio>
> using namespace clang;
> 
> @@ -26,7 +25,7 @@
> //===----------------------------------------------------------------------===//
> 
> namespace  {
> -  class VISIBILITY_HIDDEN StmtDumper : public StmtVisitor<StmtDumper> {
> +  class StmtDumper : public StmtVisitor<StmtDumper> {
>     SourceManager *SM;
>     FILE *F;
>     unsigned IndentLevel;
> 
> Modified: cfe/trunk/lib/AST/StmtPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/StmtPrinter.cpp?rev=90043&r1=90042&r2=90043&view=diff
> 
> ==============================================================================
> --- cfe/trunk/lib/AST/StmtPrinter.cpp (original)
> +++ cfe/trunk/lib/AST/StmtPrinter.cpp Sat Nov 28 13:03:38 2009
> @@ -16,7 +16,6 @@
> #include "clang/AST/DeclCXX.h"
> #include "clang/AST/DeclObjC.h"
> #include "clang/AST/PrettyPrinter.h"
> -#include "llvm/Support/Compiler.h"
> #include "llvm/Support/Format.h"
> using namespace clang;
> 
> @@ -25,7 +24,7 @@
> //===----------------------------------------------------------------------===//
> 
> namespace  {
> -  class VISIBILITY_HIDDEN StmtPrinter : public StmtVisitor<StmtPrinter> {
> +  class StmtPrinter : public StmtVisitor<StmtPrinter> {
>     llvm::raw_ostream &OS;
>     ASTContext &Context;
>     unsigned IndentLevel;
> 
> Modified: cfe/trunk/lib/AST/StmtProfile.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/StmtProfile.cpp?rev=90043&r1=90042&r2=90043&view=diff
> 
> ==============================================================================
> --- cfe/trunk/lib/AST/StmtProfile.cpp (original)
> +++ cfe/trunk/lib/AST/StmtProfile.cpp Sat Nov 28 13:03:38 2009
> @@ -20,11 +20,10 @@
> #include "clang/AST/ExprObjC.h"
> #include "clang/AST/StmtVisitor.h"
> #include "llvm/ADT/FoldingSet.h"
> -#include "llvm/Support/Compiler.h"
> using namespace clang;
> 
> namespace {
> -  class VISIBILITY_HIDDEN StmtProfiler : public StmtVisitor<StmtProfiler> {
> +  class StmtProfiler : public StmtVisitor<StmtProfiler> {
>     llvm::FoldingSetNodeID &ID;
>     ASTContext &Context;
>     bool Canonical;
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits