[cfe-commits] r89736 - in /cfe/trunk: lib/CodeGen/CGCall.cpp lib/CodeGen/CGVtable.cpp lib/CodeGen/CodeGenTypes.h test/CodeGenCXX/virtual-functions-incomplete-types.cpp

Anders Carlsson andersca at mac.com
Mon Nov 23 21:42:20 PST 2009

23 nov 2009 kl. 21.35 skrev Eli Friedman:
> I'm not sure if this matters other than the cleanliness of the IR, but
> this isn't quite the same as the normal handling for incomplete
> function types in CodeGenTypes::ConvertNewType.  Specifically, this
> bypasses the handling to resolve the opaque type to a proper function
> type.

Nope, it doesn't matter since we don't need/want to resolve the opaque type.

> Also, HasIncompleteReturnTypeOrArgumentTypes is roughly equivalent to
> VerifyFuncTypeComplete in CodeGenTypes.cpp.

Yeah, I noticed that. Will refactor.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20091123/0b24f562/attachment.html>

More information about the cfe-commits mailing list