[cfe-commits] r86915 - /cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[Devang Patel]

On Sun, Nov 22, 2009 at 6:43 AM, Chris Lattner <clattner at apple.com> wrote:
>
> On Nov 16, 2009, at 10:55 PM, Daniel Dunbar wrote:
>
>> Ok, but why is it hard for clients to pass in an empty string as the
>> default? That doesn't seem any harder than passing in 0.
>
> Clients can also pass in StringRef()  if they really want a null one?

Well... clang uses StringRef() in its interface... but not all clients.

llvm-gcc passes  IDENTIFIER_POINTER(DECL_ASSEMBLER_NAME(Node)) through
debug info API. So, here client will also have to check null if
StringRef(NULL) is not accepted.

(We're discussing same on llvm commit list also. Let's continue the
thread on that list. )
-
Devang