[cfe-commits] r86517 - in /cfe/trunk: lib/Analysis/GRExprEngineInternalChecks.cpp lib/Analysis/GRExprEngineInternalChecks.h lib/Analysis/PointerSubChecker.cpp test/Analysis/ptr-arith.c

[Zhongxing Xu]

2009/11/10 Ted Kremenek <kremenek at apple.com>:
> Hi Zhongxing,
>
> It seems to me that we should be comparing the "base" regions, not the
> regions themselves.  For example, we can have two different ElementRegions
> that refer to different locations of the same buffer, two FieldRegions that
> refer to different fields within a struct, etc., and that would be
> completely valid.  I think it's also fine to involve SymbolicRegions, since
> they just represent the base of some chunk of memory, and typically they
> will wrapped with an ElementRegion anyway.
>
> What do you think?

Yes, you're right!