[cfe-commits] r86315 - /cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[Anders Carlsson]

6 nov 2009 kl. 17.02 skrev Devang Patel:

>
> On Nov 6, 2009, at 4:59 PM, Anders Carlsson wrote:
>
>>
>> 6 nov 2009 kl. 16.29 skrev Devang Patel:
>>
>>> Author: dpatel
>>> Date: Fri Nov  6 18:29:05 2009
>>> New Revision: 86315
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=86315&view=rev
>>> Log:
>>> Do not assert if debug info for certain type is not generated.
>>>
>>
>> Why not? It's far better to assert early when you know what the  
>> type is than to assert when emitting the dwarf information. Did  
>> this break any tests?
>>
>
> Yes. FixedWidthIntType is not handled.

Ah, in that case it's better to add that to the

   // FIXME: Handle these.
   case Type::ExtVector:
   case Type::Vector:
     return llvm::DIType();

cases. Do you want me to do that?

Thanks,
Anders

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20091106/dd614c05/attachment.html>