[cfe-commits] r86107 - in /cfe/trunk: include/clang/Rewrite/HTMLRewrite.h lib/Rewrite/HTMLRewrite.cpp

[Chris Lattner]

On Nov 4, 2009, at 5:54 PM, Daniel Dunbar wrote:

> Author: ddunbar
> Date: Wed Nov  4 19:54:02 2009
> New Revision: 86107
>
> URL: http://llvm.org/viewvc/llvm-project?rev=86107&view=rev
> Log:
> Make html::{SyntaxHighlight,HighlightMacros} take a const  
> Preprocessor.
>
> This is conceptually correct, but adds a huge hack to  
> HighlightMacros which is
> in fact doing all sorts of mutation to the Preprocessor. See FIXME.

I agree on both points, we should duplicate the preprocessor.  I don't  
see this as a short term priority to actually do though.

-Chris