[cfe-commits] [PATCH] -fshort-wchar

Douglas Gregor dgregor at apple.com
Tue Nov 3 22:15:28 PST 2009

On Nov 2, 2009, at 7:01 PM, John Thompson wrote:

> Here's a stab at implementing -fshort-wchar.

Thanks! This looks good, except for two missing pieces:

   - The PCH reader and writer need to load/save the ShortWChar bit.
   - You'll need to update the clang driver to pass -fshort-wchar  
through to clang-cc

There is some weird spacing in this patch... are you using tabs in  
your editor?

+void TargetInfo::setForcedLangOptions(LangOptions &Opts) {
+	if (Opts.ShortWChar) {
+    WCharType = UnsignedShort;
+    WCharWidth = WCharAlign = 16;
+	}

> The change to the wchar.c test allows it to pass on Windows (and  
> still pass on Linux, which defaults to int for wchar_t).

I'd like to retain the test that we use "int" for the other targets.  
Could you do something like

   RUN: clang-cc %s -fsyntax-only -triple i686-pc-linux-gnu -verify - 
DWCHAR_T_TYPE="int" &&
   RUN: clang-cc %s -fsyntax-only -fshort-wchar -verify - 
DWCHAR_T_TYPE="unsigned short"

then use WCHAR_T_TYPE as the element type of the t1 and t2 arrays?

	- Doug

More information about the cfe-commits mailing list