[cfe-commits] Patch for PR5273

John McCall rjmccall at apple.com
Mon Nov 2 11:22:00 PST 2009

Brandon Pearcy wrote:
> Hi John,
> On Thu, Oct 29, 2009 at 12:48 PM, John McCall <rjmccall at apple.com 
> <mailto:rjmccall at apple.com>> wrote:
>     Like I said in the bug, I think there are common cases we can
>     green-light a warning for:  for example, if we're passing an
>     uninitialized field by reference to a copy constructor, then sure,
>     let's warn about it.  But for arbitrary function calls?  No.
> Okay, I'm going to submit a new patch that does not attempt to handle 
> function calls w/ uninit arguments. You are right; it is not smart to 
> enforce style, and it is complicated to know if the function is taking 
> a pointer or reference, in combination with any operators upon the 
> field itself. It is easier (for now) to just whitelist the function 
> call case completely.
> Sound good?

I think that's a good call.  If we become worried about function calls, 
we can write the code to white-list it later.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20091102/37b9e120/attachment.html>

More information about the cfe-commits mailing list